Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI flag to skip authentication for stats related RPC endpoints #398

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Jul 13, 2023

Closes #390

I've tested that the CLI flag reaches the correct config, but I haven't tested further.

@ffranr ffranr requested review from guggero and jharveyb July 13, 2023 12:38
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one nit, otherwise LGTM 🎉

cmd/tapcli/main.go Outdated Show resolved Hide resolved
When set, this new flag will allow the use of stats related RPC
endpoints without macaroon authentication.
Copy link
Collaborator

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

I think we could add a small itest for these whitelisted calls later on.

@guggero guggero added this pull request to the merge queue Jul 13, 2023
Merged via the queue into lightninglabs:main with commit 2c5c88a Jul 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement]: Add universe-server configuration option to enable client access without authentication
3 participants